search

eclipse / microprofile-service-mesh-service-b

microprofile-service-mesh-service-b
Apache License 2.0
1 stars 12 forks source link

First cut at including Thorntail #12

Closed pilhuhn closed 6 years ago

pilhuhn commented 6 years ago

Please especially @kenfinnigan have a look

pilhuhn commented 6 years ago

@kenfinnigan You know TT so much better than I do. I found this as a solution to set the context root, so I used it. How/were would I use the project-defaults.yml? Is that a TTv2 thingy?

kenfinnigan commented 6 years ago

so project-defaults.yml can be added to src/main/resources with content like:

swarm:
  context:
    path: '/mp-servicemesh-sample/serviceA'

That should do what you need, and it works in v2

pilhuhn commented 6 years ago

@kenfinnigan The "downside" of project-defaults.yml in src/main/resources/is that this would also be copied into a liberty (or other server) deployment, while the current approach has the file in src/main/profiles/thorntail/ and is thus more 'isolated'.

kenfinnigan commented 6 years ago

Sorry, I wasn't necessarily meaning the file had to be in src/main/resources but that it needs to be processed like it is.

Having it in a custom Thorntail folder that gets added to the /target directory on build is fine.