search

eclipse / microprofile-starter

MicroProfile project generator source code
Apache License 2.0
74 stars 51 forks source link

update liberty config #483

Closed Emily-Jiang closed 1 year ago

scottkurz commented 1 year ago

I'll close #477 then since this supersedes.

scottkurz commented 1 year ago

@Emily-Jiang sent a PR to your PR branch. https://github.com/Emily-Jiang/microprofile-starter/pull/2

Also please see my #484 separately (but next time you release).

scottkurz commented 1 year ago

Hmm...looking at the failure and recreating locally... I don't think the Liberty Gradle 3.6 is compatible with the 6.8.3 gradle wrapper.

It did work when I backed off to io.openliberty.tools:liberty-gradle-plugin:3.5.2. Will try to follow-up to understand better.

scottkurz commented 1 year ago

The GHA check failure showed:

 * What went wrong:
Execution failed for task ':installLiberty'.
> java.io.EOFException: Unexpected end of ZLIB input stream

This would seem to be when the two ./gradlew libertyPackage cmds, for A and B, are executed concurrently.

Next step is to understand why this is the case.

Emily-Jiang commented 1 year ago

Thank you @scottkurz ! I'll close this PR and push #486 forward.