search

eclipse / microprofile-telemetry

microprofile telemetry
Apache License 2.0
16 stars 16 forks source link

Spec review #128

Closed JanWesterkamp-iJUG closed 9 months ago

JanWesterkamp-iJUG commented 9 months ago

@Emily-Jiang and @Azquelt, I created this PR to update MP Telemetry regarding #80 (and #93). Please review and merge this (or I can do it with approvals).

Besides the keyword formatting I also solved some AsciiDoc formatting issues (see separate commits) and typos. @Azquelt if you want to get listed in the NOTICE files and the spec titel, please ping me or add youself there. I would suggest to replace the authors list in the spec title with something like the MP Telemetry Team to keep it short in the future, but this should be discussed and there was not time for this in the last meeting unfortunately.

@Emily-Jiang this is now rebased on the current main branch version.

JanWesterkamp-iJUG commented 9 months ago

@Emily-Jiang and @Azquelt, checks have passed now and itv is ready for review.

JanWesterkamp-iJUG commented 9 months ago

@Azquelt, should I add you to the authors list on the title page and the NOTICE files too?

Azquelt commented 9 months ago

@JanWesterkamp-iJUG no, it's fine. I've helped out a little with reviews and a couple of TCKs but I haven't contributed anything to the spec.