eclipse / microprofile-telemetry

microprofile telemetry
Apache License 2.0
19 stars 18 forks source link

Cross-release consistency of telemetry names/values #166

Open donbourne opened 6 months ago

donbourne commented 6 months ago

Users of MP Telemetry will expect to be able to use the technology across different servers that are running with apps that depend on different JEE / Jakarta EE levels. Monitoring tools that interface with MP Telemetry often provide dashboards which render context and signal data from spans, metrics and logs and that rely on the exact names of metrics or attributes.

Consistency of telemetry names/values

I believe the best options are 1b or 2. Looking for opinions on which is better.

pdudits commented 6 months ago

First let me remind that we are in fact introducting incompatibility in this release due to move to stable HTTP attributes in traces. OpenTelemetry did suggest common property to optionally emit duplicate attributes but we chose not to support it. I understand that this issue is seeking long term MP specific solution.

I agree that 1a would promote not upgrading to newer versions and is therefore undesireable.

Option 1b as you described it would require defining some translation format that could be published as an amendment to already released spec. While this is achievable, we face a risk of defining that translation format to be either too simple for our future needs or too complicated for what we will actually do.

Option 2 seems the most practical one even though bit out of place as it doesn't specify any Java API or runtime behavior.I can imagine such configuration file being a non-normative appendix of the spec. It is more practical than 1b, because Collector already exists and is designed to cover practical needs of signal transformations.

I wouldn't worry about users not being able to change their existing Collector configuration, as they should be able to deploy additional intermediate Collector that would just do the translation.

donbourne commented 6 months ago

from discussion on Mar 18th in MP Telemetry call:

Option 1b too hard?

Option 2 sounds most natural

Option 1a

Conclusion: Most people sound to be in favor of option 2 over options 1a/1b. We can try to use the changes to span names that we already have in this release as the first ones to handle this way.