search

eclipse / microprofile-telemetry

microprofile telemetry
Apache License 2.0
16 stars 16 forks source link

Move TCK from smallrye #21

Closed brunobat closed 2 years ago

Emily-Jiang commented 2 years ago

@yasmin-aumeeruddy pointed out 1.15 has not got instrumentation jar released, so we are better off to stay with 1.14.

fmhwong commented 2 years ago

I built this branch and got the following checkstyle errors.

[INFO] There are 7 errors reported by Checkstyle 8.29 with /Users/fmhwong/gitRepos/microprofile-telemetry/tracing/tck/target/checkstyle-rules.xml ruleset.
[ERROR] src/main/Java/org/eclipse/microprofile/telemetry/tracing/tck/exporter/InMemorySpanExporter.java:[25,15] (imports) UnusedImports: Unused import - org.awaitility.Awaitility.await.
[ERROR] src/main/Java/org/eclipse/microprofile/telemetry/tracing/tck/exporter/InMemorySpanExporter.java:[26,15] (imports) UnusedImports: Unused import - org.junit.jupiter.api.Assertions.assertEquals.
[ERROR] src/main/Java/org/eclipse/microprofile/telemetry/tracing/tck/TestConfigSource.java:[30,38] (naming) ConstantName: Name 'configuration' must match pattern '^(([A-Z][A-Z0-9]*(_[A-Z0-9]+)*))$'.
[ERROR] src/main/Java/org/eclipse/microprofile/telemetry/tracing/tck/rest/RestSpanTest.java:[26] (imports) AvoidStarImport: Using the '.*' form of import should be avoided - io.opentelemetry.semconv.trace.attributes.SemanticAttributes.*.
[ERROR] src/main/Java/org/eclipse/microprofile/telemetry/tracing/tck/rest/RestSpanTest.java:[49] (imports) AvoidStarImport: Using the '.*' form of import should be avoided - jakarta.ws.rs.*.
[ERROR] src/main/Java/org/eclipse/microprofile/telemetry/tracing/tck/rest/RestClientSpanTest.java:[36,15] (imports) UnusedImports: Unused import - org.junit.jupiter.api.Assertions.assertEquals.
[ERROR] src/main/Java/org/eclipse/microprofile/telemetry/tracing/tck/rest/RestClientSpanTest.java:[63] (imports) AvoidStarImport: Using the '.*' form of import should be avoided - jakarta.ws.rs.*.
[WARNING] checkstyle:check violations detected but failOnViolation set to false
JanWesterkamp-iJUG commented 2 years ago

@brunobat I reviewed this PR including your last changes (looks good), but as dicussed in the last meeting, I am not a official contributor to this repo yet. So I am unable to merge the PR at the moment. @Emily-Jiang, @brunobat can somebody give me the necessary rights? Then I can merge afterwards.

Emily-Jiang commented 2 years ago

@brunobat I reviewed this PR including your last changes (looks good), but as dicussed in the last meeting, I am not a official contributor to this repo yet. So I am unable to merge the PR at the moment. @Emily-Jiang, @brunobat can somebody give me the necessary rights? Then I can merge afterwards.

@JanWesterkamp-iJUG this blog explains how to become an Eclipse committer.