Closed brunobat closed 3 weeks ago
There are 2 implementations for this metric Thread Count. One for Java 17: io.opentelemetry.instrumentation.runtimemetrics.java17.internal.threads.ThreadCountHandler#METRIC_DESCRIPTION Another one for Java 8: https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/745d880c06676a28d75c5567aa7bd5ad68c5da2d/instrumentation/runtime-telemetry/runtime-telemetry-java8/library/src/main/java/io/opentelemetry/instrumentation/runtimemetrics/java8/Threads.java#L69
They both use different descriptions and the TCK requires the Java 8 flavour: https://github.com/eclipse/microprofile-telemetry/blob/88735b74308d123a324b66cc9c4a132f980cb541/tck/metrics/src/main/java/org/eclipse/microprofile/telemetry/metrics/tck/jvm/JvmThreadTest.java#L59
A possible solution could be to test just part of the sentence: "Number of executing". We should also submit a PR upstream to fix that in the OTel instrumentation. That will take longer.
There are 2 implementations for this metric Thread Count. One for Java 17: io.opentelemetry.instrumentation.runtimemetrics.java17.internal.threads.ThreadCountHandler#METRIC_DESCRIPTION Another one for Java 8: https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/745d880c06676a28d75c5567aa7bd5ad68c5da2d/instrumentation/runtime-telemetry/runtime-telemetry-java8/library/src/main/java/io/opentelemetry/instrumentation/runtimemetrics/java8/Threads.java#L69
They both use different descriptions and the TCK requires the Java 8 flavour: https://github.com/eclipse/microprofile-telemetry/blob/88735b74308d123a324b66cc9c4a132f980cb541/tck/metrics/src/main/java/org/eclipse/microprofile/telemetry/metrics/tck/jvm/JvmThreadTest.java#L59
A possible solution could be to test just part of the sentence: "Number of executing". We should also submit a PR upstream to fix that in the OTel instrumentation. That will take longer.