Open pilhuhn opened 1 year ago
As @WithSpan
is part of OTel, we should probably use a different annotation (MP-specific) for the errorOn
attribute.
Hi Heiko, The OTel spec has the concept of Sampler, to drop spans that are not needed. This use case seems to fit it. I don't think there is the need for a specific annotation. The rest-client spec can potentially be updated to include one of these filters. See an example: https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/examples/extension/src/main/java/com/example/javaagent/DemoSampler.java
@Azquelt will take a further look at this.
Description
As a:
...I need to be able to:
Mark an interface for a rest-client so that certain return codes trigger marking the span as failed
Something like
and then in the interceptor code do
...which enables me to: Get non-behaving remote client calls into the trace without manually wrap all the remote client calls into the mentioned code manually.