search

eclipse / microprofile-telemetry

microprofile telemetry
Apache License 2.0
16 stars 16 forks source link

Removed Servlet TCK #40

Closed yasmin-aumeeruddy closed 1 year ago

yasmin-aumeeruddy commented 1 year ago

I have removed the servlet test from the telemetry tck as discussed in the MPTelemetry call earlier today

brunobat commented 1 year ago

Something weird is going on with this build... I've checked out the PR and did a build with java 8:

Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0)
Maven home: /Users/bbaptist/.sdkman/candidates/maven/current
Java version: 1.8.0_345, vendor: Azul Systems, Inc., runtime: /Users/bbaptist/.sdkman/candidates/java/8.0.345-zulu/zulu-8.jdk/Contents/Home/jre
Default locale: en_PT, platform encoding: UTF-8
OS name: "mac os x", version: "12.5.1", arch: "aarch64", family: "mac"

And the build works... The missing class: 

/home/runner/.m2/repository/jakarta/ws/rs/jakarta.ws.rs-api/3.1.0/jakarta.ws.rs-api-3.1.0.jar(jakarta/ws/rs/ApplicationPath.class)

Is not even a dependency in the project: [INFO] +- jakarta.ws.rs:jakarta.ws.rs-api:jar:3.0.0:provided And we have a warning on the beginning of the build:

Warning:  'dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: jakarta.ws.rs:jakarta.ws.rs-api:jar -> version (?) vs 3.1.0 @ line 79, column 21
Emily-Jiang commented 1 year ago

Something weird is going on with this build... I've checked out the PR and did a build with java 8:

Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0)
Maven home: /Users/bbaptist/.sdkman/candidates/maven/current
Java version: 1.8.0_345, vendor: Azul Systems, Inc., runtime: /Users/bbaptist/.sdkman/candidates/java/8.0.345-zulu/zulu-8.jdk/Contents/Home/jre
Default locale: en_PT, platform encoding: UTF-8
OS name: "mac os x", version: "12.5.1", arch: "aarch64", family: "mac"

And the build works... The missing class:

/home/runner/.m2/repository/jakarta/ws/rs/jakarta.ws.rs-api/3.1.0/jakarta.ws.rs-api-3.1.0.jar(jakarta/ws/rs/ApplicationPath.class)

Is not even a dependency in the project: [INFO] +- jakarta.ws.rs:jakarta.ws.rs-api:jar:3.0.0:provided And we have a warning on the beginning of the build:

Warning:  'dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: jakarta.ws.rs:jakarta.ws.rs-api:jar -> version (?) vs 3.1.0 @ line 79, column 21

@brunobat yes, the github actions reported the same. One dependency from the parent pom is to be deleted. Now, the build ran ok.