search

eclipse / microprofile-telemetry

microprofile telemetry
Apache License 2.0
16 stars 16 forks source link

Implement tests in a way that is not timestamp dependent #44

Closed brunobat closed 11 months ago

brunobat commented 1 year ago

This line assumes spans will arrive in order: https://github.com/eclipse/microprofile-telemetry/blob/bac62306cca48c46d8f19022efe3e656f59a3846/tracing/tck/src/main/java/org/eclipse/microprofile/telemetry/tracing/tck/exporter/InMemorySpanExporter.java#L52 That is not true in all cases. A new method to get spans is needed where you pass some filters like the parent span id, span type, target... This will allow sturdy assertions.

Emily-Jiang commented 1 year ago

@brunobat do you have the details for this issue? If you do, please post it here. Otherwise, please close it.

brunobat commented 1 year ago

@Emily-Jiang I've updated the description

Emily-Jiang commented 1 year ago

@Azquelt @yasmin-aumeeruddy will take a look at this.

Emily-Jiang commented 1 year ago

This issue might be fixed by #95