search

eclipse / microprofile-telemetry

microprofile telemetry
Apache License 2.0
19 stars 18 forks source link

TCK cannot be run using the Arquillian REST protocol #72

Closed Azquelt closed 1 year ago

Azquelt commented 1 year ago

Describe the bug

Arquillian recently introduced the REST 3.0 testing protocol to allow remote and managed testing in environments where the servlet APIs are not present.

It would be nice to be able to use this so that the MP Telemetry TCK can be run in an environment which strictly only provides Jakarta EE core (which does not include servlet).

However, the rest requests made by arquillian have spans created for them which causes some of our tests to fail because there are more spans than expected collected by the InMemorySpanExporter.

We could fix this by either detecting and ignoring spans created by arquillian, or by somehow marking the spans which are part of the test.

Emily-Jiang commented 1 year ago

@Azquelt does this need to be fixed prior to 1.0 release?

Azquelt commented 1 year ago

I don't think so. It would only cause problems for an implementer who could not provide a servlet container, and I don't think there are any of those at the moment.

However, if there someone did want to certify and could not provide a servlet container, I think this would be a valid challenge and it would invalidate most of the tests so we should definitely make sure we do it for the next release.