eclipse / microprofile-telemetry

microprofile telemetry
Apache License 2.0
19 stars 18 forks source link

Test propagation for tracing #97

Closed yasmin-aumeeruddy closed 1 year ago

yasmin-aumeeruddy commented 1 year ago

Tests the use of different propagation formats, including that the right headers are set

For isse #89

pdudits commented 1 year ago

I'm not convinced the specification requires propagators that are not part of core distribution to be available out of the box.

The W3C propagation tests are allright, tests for other protocols should package appropriate library (opentelemetry-extension-trace-propagators) to make the implementations available for service discovery.

Azquelt commented 1 year ago

I'm not convinced the specification requires propagators that are not part of core distribution to be available out of the box.

I think we should clarify this in the spec. Currently we link to the page for SDK Autoconfigure and say that all properties related to tracing are supported, and that includes options for jaeger and B3.

If we only expect the propagators from the core distribution to be present, we need to state that in the spec. Similarly if we expect users to be able to provide them themselves, we should test that too (to ensure that any runtimes which do provide them out of the box don't fail if they're also provided in the application).

pdudits commented 1 year ago

Yes, with regards I was thinking about enumerating the properties in the spec. This would help us being independent from alpha-state of SDK autoconfigure as well as being flexible in which version of SDK is actually available in an implementation.

I'll try to make a spec PR regarding that

pdudits commented 1 year ago

103 attempts to clarify minimal requirements for propagators, as well as exporters and samplers.

Emily-Jiang commented 1 year ago

@yasmin-aumeeruddy please fix the build errors.