Content assist shows to many elements

eclipse / mita

mita

Eclipse Public License 2.0

56 stars 20 forks source link

Content assist shows to many elements #334

Open tkutz opened 5 years ago

tkutz commented 5 years ago

Current behavior:

The content assist shows too many elements. Selecting the wrong ones results in compilation errors.

Expected behavior:

Only elements that are relevant in the corresponding context should be provided.

List of issues:

[ ] In event handler code, feature call on sensor should only show modalities
[ ] Feature call on variable should only show type members and available extension methods
[ ] Feature call on modality should only show type members and available extension methods
[x] Content assist for setup block should filter for imported platforms

tkutz commented 5 years ago

I took a look into this but it seems to be trickier than I thought. When having typed mysensor01. and pressing [ctrl+space] after the dot, I end up in the scoping rule for ElementReferenceExpression_reference which is clear so far. However, the feature call owner mysensor01 does not refer to a Sensor type; it refers to a TypeKind. I find that quite confusing, as it also breaks hyperlinking.

tkutz commented 5 years ago

Working branch is "334-scoping"