Sizes as Types - Githubissues

eclipse / mita

mita

Eclipse Public License 2.0

56 stars 20 forks source link

Closed wegendt-bosch closed 5 years ago

wegendt-bosch commented 5 years ago

Closes #2

wegendt-bosch commented 5 years ago

jenkins retest this please now that we fixed xtext?

wegendt-bosch commented 5 years ago

jenkins retest this please I was impatient

wegendt-bosch commented 5 years ago

Review:

underscore to question mark
optional to specify size parameters, empty list -> leave out (string, not string<>)

wegendt-bosch commented 5 years ago

It turns out that making only size parameters optional is more complicated than I thought. Would it be ok to allow only the following for now:

var a: string;
var b: string<?>;
var c: array;
var d: array<uint8, ?>

but not:

var e: array<uint8>

so only all or no type arguments specified is allowed.

csweichel commented 5 years ago

so only all or no type arguments specified is allowed.

Sounds good to me ... the rule is straight forward enough to be easy to understand and enables the var a: string use-case.