Closed kschrab closed 3 weeks ago
had a very brief read and came up with following things:
getSimpleSensor()
enable()
those separately?getLidarSensorModule()
and getSimpleSensorModule()
as two different modulesDefaultSensorModule
and not SensorModule
(cmp AdhocModule / CellModule) (I don't fully understand why you want to split this very little functionality into the interface SensorModule, this only makes sense if you can reuse it, like for the Sensor<T>
). I would merge Default + SensorModule
Description
BasicSensorModule
is a single-value based sensor model which can be used to detect icy or rainy areas (e.g., viagetOs().getBasicSensorModule().getStrengthOf(SensorType.ICE)
. This replaces the methodgetOs().getStateOfEnvironmentSensor(SensorType.ICE)
in the generalOperatingSystem
. The data for this sensor module is produced by theEnvironmentAmbassador
.LidarSensorModule
provides access to the previously addedPointCloud
structure which is produced by vehicle simulators such as PHABMACS or Carla.VehicleUnit
s are able to use the new sensor modules.WeatherWarningApp
).Issue(s) related to this PR
Affected parts of the online documentation
Changes in the documentation required?
Definition of Done
Prerequisites
Required
type(scope): description
(in the style of Conventional Commits)enhancement
, orbugfix
)origin/main
has been merged into your Fork.Requested (can be enforced by maintainers)
Special notes to reviewer