eclipse / mosquitto

Eclipse Mosquitto - An open source MQTT broker
https://mosquitto.org
Other
8.62k stars 2.33k forks source link

Fix persist plugin expiry #3016

Open NorbertHeusser opened 3 months ago

NorbertHeusser commented 3 months ago

Thank you for contributing your time to the Mosquitto project!

Before you go any further, please note that we cannot accept contributions if you haven't signed the Eclipse Contributor Agreement. If you aren't able to do that, or just don't want to, please describe your bug fix/feature change in an issue. For simple bug fixes it is can be just as easy for us to be told about the problem and then go fix it directly.

Then please check the following list of things we ask for in your pull request:


codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 83.11688% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 81.23%. Comparing base (09f0395) to head (fa6bb8b). Report is 4 commits behind head on develop.

Files Patch % Lines
test/unit/broker/persist_read_stubs.c 66.66% 8 Missing :warning:
test/unit/broker/subs_stubs.c 0.00% 3 Missing :warning:
plugins/persist-sqlite/base_msgs.c 90.00% 1 Missing :warning:
src/database.c 90.90% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3016 +/- ## =========================================== + Coverage 81.20% 81.23% +0.02% =========================================== Files 188 188 Lines 31733 31767 +34 =========================================== + Hits 25769 25806 +37 + Misses 5964 5961 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-advanced-security[bot] commented 3 months ago

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.