The pkgconfig files currently hardcode the library directory as${prefix}/lib, but the library installation directory in config.mk is set as ${prefix}/lib${LIB_SUFFIX}. This causes a mismatch between the library installation directory and the pkgconfig file on redhat-based 64-bit systems.
This commit remedies the issue for both the Makefile and CMake build by modifying the pkgconfig files to use CMAKE_INSTALL_LIBDIR instead of lib. In the CMake system, this directly reflects the installation path. The Makefiles were modified to replace CMAKE_INSTALL_LIBDIR with lib${LIB_SUFFIX}, matching the libdir definition in config.mk and following the pattern used in defining the prefix.
Thank you for contributing your time to the Mosquitto project!
Before you go any further, please note that we cannot accept contributions if
you haven't signed the Eclipse Contributor Agreement.
If you aren't able to do that, or just don't want to, please describe your bug
fix/feature change in an issue. For simple bug fixes it is can be just as easy
for us to be told about the problem and then go fix it directly.
Then please check the following list of things we ask for in your pull request:
The pkgconfig files currently hardcode the library directory as
${prefix}/lib
, but the library installation directory inconfig.mk
is set as${prefix}/lib${LIB_SUFFIX}
. This causes a mismatch between the library installation directory and the pkgconfig file on redhat-based 64-bit systems.This commit remedies the issue for both the Makefile and CMake build by modifying the pkgconfig files to use
CMAKE_INSTALL_LIBDIR
instead oflib
. In the CMake system, this directly reflects the installation path. The Makefiles were modified to replaceCMAKE_INSTALL_LIBDIR
withlib${LIB_SUFFIX}
, matching thelibdir
definition inconfig.mk
and following the pattern used in defining theprefix
.Thank you for contributing your time to the Mosquitto project!
Before you go any further, please note that we cannot accept contributions if you haven't signed the Eclipse Contributor Agreement. If you aren't able to do that, or just don't want to, please describe your bug fix/feature change in an issue. For simple bug fixes it is can be just as easy for us to be told about the problem and then go fix it directly.
Then please check the following list of things we ask for in your pull request:
make test
with your changes locally?