Notify listeners even in case newFocus is not a VControl

eclipse / nebula

Nebula Project

https://eclipse.org/nebula

Eclipse Public License 2.0

84 stars 98 forks source link

Closed mikoeh closed 2 years ago

eclipse-nebula-bot commented 2 years ago

Can one of the admins verify this patch?

mikoeh commented 2 years ago

I have accidentaly commited as user mko while my github account runs with the user mikoeh as which I have signed the ECA.

wimjongman commented 2 years ago

@mikoeh, you have to sign the ECA before we can accept patches. Make sure to use an Eclipse account with the same email as your GitHub account.

wimjongman commented 2 years ago

There is a project with CDateTime tests. Can you run this?

mikoeh commented 2 years ago

I ran the tests in

Both had test failures before my change and they are 100% identical after my change.

wimjongman commented 2 years ago

Can one of the admins verify this patch?

Ok to test

wimjongman commented 2 years ago

Thank you @mikoeh! Congratulations on your first Nebula patch. We are looking forward to seeing more of you.