eclipse / nebula

Nebula Project
https://eclipse.org/nebula
Eclipse Public License 2.0
84 stars 98 forks source link

Add Check CheckTableCombo allowing to have checkbox in multi combo - … #535

Closed zxmulsii151 closed 2 months ago

zxmulsii151 commented 10 months ago

…from release 1.1.0

eclipse-nebula-bot commented 10 months ago

Can one of the admins verify this patch?

lcaron commented 10 months ago

Very goog job, thank you for this PR. I've made a few comments

lcaron commented 7 months ago

@zxmulsii151 Any news about this PR ? If you could fix it, it should be nice because it is very interesting and will provide new features for this widget.

merks commented 6 months ago

This seems to be completely stalled. The package names don't appear correct, so I'm not sure how the buidl worked. There are no copyright/license headers on the new files. If this doesn't move forward, we should close it...

lcaron commented 6 months ago

This functionnality is interesting... Sad that this PR is going to be trashed :'(

zxmulsii151 commented 5 months ago

Dear All,

Sorry I tried several times to fix it but I didn't succeed. Sorry for the Inconvenience. Do any of you copy the code, clean it and publish it again please ?

Best regards Olivier TITILLON

On Sun, Feb 11, 2024 at 8:57 PM Laurent CARON @.***> wrote:

This functionnality is interesting... Sad that this PR is going to be trashed :'(

— Reply to this email directly, view it on GitHub https://github.com/eclipse/nebula/pull/535#issuecomment-1937852718, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7NI6U5WBDNZVZVKPCJMRBDYTEPA3AVCNFSM6AAAAAA5PLNV3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZXHA2TENZRHA . You are receiving this because you were mentioned.Message ID: @.***>

The information in this e-mail is confidential. The contents may not be disclosed or used by anyone other than the addressee. Access to this e-mail by anyone else is unauthorised. If you are not the intended recipient, please notify Airbus immediately and delete this e-mail. Airbus cannot accept any responsibility for the accuracy or completeness of this e-mail as it has been sent over public networks. If you have any concerns over the content of this message or its Accuracy or Integrity, please contact Airbus immediately. All outgoing e-mails from Airbus are checked using regularly updated virus scanning software but you should take whatever measures you deem to be appropriate to ensure that this message and any attachments are virus free.

lcaron commented 5 months ago

Bonjour Olivier (I suppose you're french).

I'll handle this. Thank you for your contribution.

Laurent

zxmulsii151 commented 5 months ago

Dear Laurent,

Many thanks for handle this. Could you please let me know when it's done ?

Olivier

On Tue, Feb 27, 2024 at 3:42 PM Laurent CARON @.***> wrote:

Bonjour Olivier (I suppose you're french).

I'll handle this. Thank you for your contribution.

Laurent

— Reply to this email directly, view it on GitHub https://github.com/eclipse/nebula/pull/535#issuecomment-1966705546, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7NI6U55G7F3YIX3ZFPAWATYVXWFNAVCNFSM6AAAAAA5PLNV3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRWG4YDKNJUGY . You are receiving this because you were mentioned.Message ID: @.***>

The information in this e-mail is confidential. The contents may not be disclosed or used by anyone other than the addressee. Access to this e-mail by anyone else is unauthorised. If you are not the intended recipient, please notify Airbus immediately and delete this e-mail. Airbus cannot accept any responsibility for the accuracy or completeness of this e-mail as it has been sent over public networks. If you have any concerns over the content of this message or its Accuracy or Integrity, please contact Airbus immediately. All outgoing e-mails from Airbus are checked using regularly updated virus scanning software but you should take whatever measures you deem to be appropriate to ensure that this message and any attachments are virus free.

lcaron commented 2 months ago

Hi olivier

You code has been included in Nebula : https://github.com/eclipse/nebula/pull/595

Thank you for your contribution

lcaron commented 2 months ago

PR Canceled and replaced by https://github.com/eclipse/nebula/pull/595