search

eclipse / nebula

Nebula Project
https://eclipse.org/nebula
Eclipse Public License 2.0
85 stars 98 forks source link

Fix the Slider#computeSize method to take the real height into account #580

Closed laeubi closed 4 months ago

laeubi commented 6 months ago

Currently the slider is displayed quite big compared to other SWT controls (e.g. labels) and even if one make the slider height smaller this does not really change much using the usual SWT layout managers. The reason for this is that the slider currently reports a minimum height of 40 instead of query the real selector height.

This now reports the real height the control will be painted including a one pixel padding on top/bottom for antialiasing effects to be correctly shown.

lcaron commented 6 months ago

Nice contribution, thank you @laeubi