search

eclipse / nebula

Nebula Project
https://eclipse.org/nebula
Eclipse Public License 2.0
84 stars 97 forks source link

CDateTime: Fix interference of text editing and opening picker #597

Closed christianmichaelis closed 1 month ago

christianmichaelis commented 1 month ago

fixes https://github.com/eclipse/nebula/issues/593

merks commented 1 month ago

In order to be able to merge your pull request we need you to complete the Eclipse Contribution Agreement, ECA. These instructions are quite helpful/detailed:

https://github.com/eclipse-platform/.github/blob/main/CONTRIBUTING.md#setting-up-your-eclipse-and-github-account

christianmichaelis commented 1 month ago

I just tried to fix the ECA problem. As I used another Email for my Eclipse account, I put my GitHub username in the Eclipse profile. Is this sufficient? How do I re-trigger the check?

merks commented 1 month ago

I think it will be okay:

image

But I'm not sure why it's taking so long to update the status here...

merks commented 1 month ago

@lcaron

It looks safe to me, but I don't have deep knowledge...

lcaron commented 1 month ago

PR merge. Thank you @christianmichaelis for this bugfix and @merks for your support.