search

eclipse / nebula

Nebula Project
https://eclipse.org/nebula
Eclipse Public License 2.0
84 stars 98 forks source link

Floating Text widget not usable on Linux #81

Closed vogella closed 3 years ago

vogella commented 5 years ago

The Floating Text Widget was created via #11 I just clone the repo and executed FloatingTextSnippet and here is the result:

image

This looks wrong.

wimjongman commented 5 years ago

Thanks, I will take a look.

vogella commented 5 years ago

Thanks, Wim.

On Tue, May 7, 2019 at 4:08 PM Wim Jongman notifications@github.com wrote:

Thanks, I will take a look.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/eclipse/nebula/issues/81#issuecomment-490095386, or mute the thread https://github.com/notifications/unsubscribe-auth/AABCFBSCLCHIKG4PT7M63J3PUGENPANCNFSM4HLHZN2A .

-- Eclipse Platform project co-lead CEO vogella GmbH

Haindaalwisch 17a, 22395 Hamburg Amtsgericht Hamburg: HRB 127058 Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel USt-IdNr.: DE284122352 Fax (040) 5247 6322, Email: lars.vogel@vogella.com, Web: http://www.vogella.com

wimjongman commented 5 years ago

This is what I see when running on Linux Ubuntu 18.0.4. Far from perfect but no artifacts.

image

vogella commented 5 years ago

I'm using Ubuntu 19.04 but I guess this can be related to my low screenresolution.

Can you try with 1152x864 screen resolution?

On Wed, May 8, 2019 at 3:59 PM Wim Jongman notifications@github.com wrote:

This is what I see when running on Linux Ubuntu 18.0.4. Far from perfect but no artifacts.

[image: image] https://user-images.githubusercontent.com/180969/57380957-4eaf4880-71aa-11e9-99ef-5d1aa0415111.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/eclipse/nebula/issues/81#issuecomment-490497116, or mute the thread https://github.com/notifications/unsubscribe-auth/AABCFBTDQAISJKFIYGQRU6DPULMFTANCNFSM4HLHZN2A .

-- Eclipse Platform project co-lead CEO vogella GmbH

Haindaalwisch 17a, 22395 Hamburg Amtsgericht Hamburg: HRB 127058 Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel USt-IdNr.: DE284122352 Fax (040) 5247 6322, Email: lars.vogel@vogella.com, Web: http://www.vogella.com

vogella commented 4 years ago

@wimjongman did you try this again?

lcaron commented 4 years ago

Lars Hi checked on Fedora with you resolution, but it works fine :'(

I suggest you to have a look at the FloatingText class, method doSetLabelText line 283 FontData[] fontData = fLabel.getFont().getFontData(); FontData[] newFontData = new FontData[fontData.length]; int height = fLabel.getSize().y - 2 - (fLabel.getBorderWidth() * 2); height = height > 0 ? height : 2; height = (int) Math.round(height * 72 / getDisplay().getDPI().y); for (int i = 0; i < fontData.length; i++) { newFontData[i] = new FontData(fontData[i].getName(), height, fontData[i].getStyle()); newFontData[i].setLocale(fontData[i].getLocale()); }

I'll be curious to know the value of "height"...

Thanks Laurent

vogella commented 3 years ago

Sorry for the long, long, long delay in response. Just retested and it looks great on Linux these days.

Thanks!

wimjongman commented 3 years ago

Thanks for the feedback, Lars.