Closed 0xdaryl closed 3 years ago
In the very short term, the findOrCreateLiteral
function can move from the FrontEnd class into the OMR::Z::CodeGenerator
class and the references fixed up. It will still be unimplemented.
The sequence of staged PRs to simply move the function from FrontEnd class to the Z CodeGenerator is:
findOrCreateLiteral
to the OMR::Z::CodeGenerator
class (#2843)
The only implementation of
findOrCreateLiteral()
in the FrontEnd always ends in an unimplemented assertion, despite being on seemingly active code paths in the Z code generator. No known downstream project provides an implementation either.This issue was discussed with @fjeremic prior to open-sourcing this code, and the following is a summary of our discussion at that time:
I will leave this issue marked as a "Discussion" until we decide on how to proceed. If we decide to provide an implementation then this will become an Epic task to track the work items.