Make sure optimizations are aware about wrtbar/rdbars

eclipse / omr

Eclipse OMR™ Cross platform components for building reliable, high performance language runtimes

http://www.eclipse.org/omr

Other

940 stars 394 forks source link

Make sure optimizations are aware about wrtbar/rdbars #3033

Open cathyzhyi opened 5 years ago

cathyzhyi commented 5 years ago

Wrtbar and rdbar opcodes are added in https://github.com/eclipse/omr/pull/3027. More investigation is needed for optimal performance result to make sure the opts working for a normal store/load also work for wrtbar/rdbar .

[ ] cleanup logic related to global opcode mapping. wrtbar/rdbar shouldn'd have global mapping in omr level https://github.com/eclipse/omr/pull/3224#issuecomment-441123017
[ ] PRE, field privatizer and idiom recognition are current disabled.

0xdaryl commented 5 years ago

@cathyzhyi: just to clarify, this is for performance rather than functional correctness?

cathyzhyi commented 5 years ago

@0xdaryl yes, it's for performance and the opcodes are functionally working now.

cathyzhyi commented 5 years ago

the PR disabled PRE and FieldPrivatizer for functional correctness https://github.com/eclipse/omr/pull/3224