Open rwy7 opened 4 years ago
looks we are building with --enable-native-encoding
. I thinking that something funny may be happenign with the tagging/autoconversion.
Likely a similar issue to that fixed in #4178. If we are reading from an XML I suspect we're using the port library to do so, so we'll need to add OMR_EBCDIC
guards to disable ASCII to EBCDIC conversion since we are reading using native encoding in OMR.
@fjeremic pugixl bypasses the port library (you just pass it a file name)
Based on aquick glance at the code it looks like pugixml does fopen(path_, "rb");
. Without reading the docs, I'd guess that by passing the 'b' flag to fopen, you disable auto-conversion.
This is likely the case. According to [1]:
Automatic conversion for untagged UNIX files can only take place between IBM-1047 and ISO8859-1 code sets. Other CCSID pairs are not supported. By default, automatic conversion for untagged files applies only to files opened in text mode. An untagged file opened in binary mode is not converted automatically. You can control this by using the _EDC_AUTOCVT_BINARY environment variable. For more information about the _EDC_AUTOCVT_BINARY environment variable, see z/OS XL C/C++ Programming Guide.
[1] https://www.ibm.com/support/knowledgecenter/en/SSLTBW_2.3.0/com.ibm.zos.v2r3.ceea500/filtag.htm
Is this test also failing in the PR builds?
It would, if we were to run the test. We only run 8 different tests in PR builds. See [2]. Recently though as part of #4290 we synchronized so the Build and PR pipelines run the exact same thing. This issue was opened as a result to track fixing the problem which was only previously observed in Build pipelines, as they were the only ones running this GC test.
This issue is stale because it has been open 180 days with no activity. Remove stale label or comment on the issue or it will be closed in 60 days.
Issue still valid, removing stale label.
The GC tests have been disabled on zos, due to an xml parsing issue. The issue needs to be fixed, and the tests need to be reenabled.
Failing output from last build:
/cc @dnakamura @youngar @fjeremic