search

eclipse / omr

Eclipse OMR™ Cross platform components for building reliable, high performance language runtimes
http://www.eclipse.org/omr
Other
940 stars 394 forks source link

Remove or replace OMR::ILOpCode::setTarget() ? #6723

Open gita-omr opened 1 year ago

gita-omr commented 1 year ago

The setTarget() method [1] does not seem to be used, at least in omr and openj9. In addition, the comments indicate that the approach is not correct.

[1] https://github.com/eclipse/omr/blob/24b511df5a7d1cb6638802fb68219e9c421d3af1/compiler/il/OMRILOps.cpp#L63

gita-omr commented 1 year ago

@0xdaryl fyi

gita-omr commented 1 year ago

Recently, we used the approach in [1] to make data type size to be determined at runtime.

[1] https://github.com/eclipse/omr/blob/24b511df5a7d1cb6638802fb68219e9c421d3af1/compiler/il/OMRDataTypes.cpp#L191