search

eclipse / omr

Eclipse OMR™ Cross platform components for building reliable, high performance language runtimes
http://www.eclipse.org/omr
Other
940 stars 394 forks source link

Correct Z opcode properties #7066

Open Spencer-Comin opened 1 year ago

Spencer-Comin commented 1 year ago

In https://github.com/eclipse/omr/pull/6447 I corrected some s390 opcode properties. There are likely more incorrect properties.

Correcting the properties will break code that relies on the incorrect properties, e.g. https://github.com/eclipse-openj9/openj9/issues/17804.

This issue is for tracking fixes to the opcode properties and to the code that relies on incorrect properties.

Opcode properties: https://github.com/eclipse/omr/blob/master/compiler/z/codegen/OMRInstOpCodeProperties.hpp

Spencer-Comin commented 1 year ago

The different store multiple opcodes have UsesRegRangeForTarget, those should be corrected to UsesRegRangeForSource

Spencer-Comin commented 1 year ago

Looking into the properties, there is no UsesRegRangeForSource property. If there is no place where this property is checked where it matters whether the range is a source or target, a more correct name might be just UsesRegRange

Spencer-Comin commented 1 year ago

The various cipher message and compute message opcodes need ImplicitlyUsesGPR0 and ImplicitlyUsesGPR1 added