search

eclipse / omr

Eclipse OMR™ Cross platform components for building reliable, high performance language runtimes
http://www.eclipse.org/omr
Other
934 stars 392 forks source link

x86: Cache supportsAVX() checks in binary encoding #7311

Open BradleyWood opened 2 months ago

BradleyWood commented 2 months ago

A profile discovered significant compute time spent running these checks. I will add performance numbers shortly.

BradleyWood commented 2 months ago

@dsouzai Can you look at this PR from the perspective of CRIU and JIT-server?

FYI, @0xdaryl @vijaysun-omr

dsouzai commented 2 months ago

These checks were originally added because OpenJ9 moved from using TR::CodeGenerator::getX86ProcessorInfo() to using the port library, and so these were sanity checks to ensure that the two sources of information agreed with each other.

Given that it's been a few years, do we even need these checks? @mpirvu what do you think?

BradleyWood commented 2 months ago

Given that it's been a few years, do we even need these checks?

I am working on removing the old api in favour of the portlibrary.