search

eclipse / omr

Eclipse OMR™ Cross platform components for building reliable, high performance language runtimes
http://www.eclipse.org/omr
Other
934 stars 392 forks source link

Change arraycmp length child to 64 bits #7313

Closed Spencer-Comin closed 2 weeks ago

Spencer-Comin commented 2 months ago

Previously the arraycmp IL opcode's length child was specified as 32 bits but was inconsistent in its use. This commit changes the specification of the length child to 64 bits, and normalizes the use to 64 bits.

Closes: #6992

Spencer-Comin commented 2 months ago

x86-64 macOS failure is https://github.com/eclipse/omr/issues/7181.

Pinging @0xdaryl, @zl-wang, and @r30shah as I made tweaks to AArch64, Power, and Z codegens.

Spencer-Comin commented 2 months ago

I ran some internal sanity tests and saw some issues with i386. I made a minor change in the x86 codegen; @hzongaro could you review that?

After the x86 changes the only testing failures I am seeing seem to be infrastructure related (see internal jenkins tests here and here).

r30shah commented 1 month ago

jenkins build all

r30shah commented 3 weeks ago

@Spencer-Comin In the last launched build there seems to be failures in riscv. Can you check?

Spencer-Comin commented 3 weeks ago

The riscv failure looks like an infra failure

...
10:37:07  Still waiting to schedule task
10:37:07  All nodes of label ‘compile:riscv64:cross` are offline
18:36:52  Cancelling nested steps due to timeout
...
r30shah commented 3 weeks ago

jenkins build all

r30shah commented 2 weeks ago

Launched build with riscv64 still failed with All nodes of label ‘[compile:riscv64:cross](https://ci.eclipse.org/omr/label/compile%3Ariscv64%3Across/)’ are offline.

@IBMJimmyk / @zl-wang can we get your review for P changes as well ?

IBMJimmyk commented 2 weeks ago

I looked over the P changes inside compiler/p/codegen/OMRTreeEvaluator.cpp and they all look good.

r30shah commented 2 weeks ago

Thanks @IBMJimmyk . @hzongaro / @0xdaryl I think this one is goof to merge. Can we request you to review/merge these changes ?

hzongaro commented 2 weeks ago

Changes have been reviewed by people familiar with the code generation for the various platforms. Merging.