eclipse / omr

Eclipse OMR™ Cross platform components for building reliable, high performance language runtimes
http://www.eclipse.org/omr
Other
933 stars 392 forks source link

OffHeap Changes #7345

Closed rmnattas closed 1 week ago

rmnattas commented 1 month ago

Changes to support OffHeap

rmnattas commented 1 month ago

Failure in CI JitBuilder testing, looking into it

Assertion failed at /home/vsts/work/1/s/compiler/il/OMRNode.cpp:212: self()->hasSymbolReference() + self()->hasRegLoadStoreSymbolReference() + self()->hasBranchDestinationNode() + self()->hasBlock() + self()->hasArrayStride() + self()->hasPinningArrayPointer() + self()->hasDataType() <= 1
_unionPropertyA union is not disjoint for this node aloadi (0x55a674c83880):
has({SymbolReference, ...}, ..., DataType) = ({1,0},0,0,0,1,0)
rmnattas commented 1 month ago

Fixed

vijaysun-omr commented 3 weeks ago

For the loop versioner commit, I would like @jdmpapin to also review.

There is a typo in that loop versioner commit message : "to use the chilid of aloadi tree"

rmnattas commented 3 weeks ago

Changes for enabling pinning array for all nodes causes a failure now, looking at it. Also working on the comments (not sure of tree shapes myself as I didn't do the code but will understand and comment).

rmnattas commented 2 weeks ago

I updated the VPHandler code and added comments, please review changes. Also added a i2l check for the stride==1 case which didn't exist originally but I believe is needed.

vijaysun-omr commented 2 weeks ago

The additional comments and changes help. The code looks somewhat easier to follow. I'll wait for Devin's review as well

vijaysun-omr commented 1 week ago

Jenkins build all

vijaysun-omr commented 1 week ago

Checks have passed. Merging.