search

eclipse / omr

Eclipse OMR™ Cross platform components for building reliable, high performance language runtimes
http://www.eclipse.org/omr
Other
933 stars 392 forks source link

Implement RSSReport class #7349

Open gita-omr opened 1 month ago

gita-omr commented 1 month ago
gita-omr commented 1 month ago

Fixed white spaces.

gita-omr commented 1 month ago

Removed Options.hpp include since it's not needed.

gita-omr commented 1 month ago

Build fixes.

gita-omr commented 1 month ago

Fix for windows build.

gita-omr commented 1 month ago

Another Windows build fix.

gita-omr commented 1 month ago

More Windows build fixes.

gita-omr commented 1 month ago

Another Windows warning.

gita-omr commented 1 month ago

another warning

gita-omr commented 1 month ago

Corrected second commit

gita-omr commented 1 month ago

I will fix line endings together with PR comments.

gita-omr commented 1 month ago

Fixed Mac build and line endings.

gita-omr commented 1 month ago

FYI: @mpirvu @tajila

Note: further improvements are possible: 1) options for reporting only specific types of memory (e.g. data cache only, code cache only etc.) 2) disclaiming regions from within the class

gita-omr commented 1 month ago

Addressed comments above.

gita-omr commented 1 month ago

Sorry, did not create a document yet. I will after we finalize the design in this PR.

gita-omr commented 3 weeks ago

Addressed comments and rebased

gita-omr commented 3 weeks ago

Made loop in addRSSItem() more sequential to avoid an extra store of the item size into memory.

gita-omr commented 3 weeks ago

Fixed white spaces.

gita-omr commented 3 weeks ago

Addressed latest comments.

gita-omr commented 3 weeks ago

I see a problem with setting page size after adding a region - printout can happen in between. I will make page parameter mandatory for the constructor. Making WIP for now.

gita-omr commented 3 weeks ago

Removed default RSSRegion constructor to make sure all instance variables are properly initialized as soon as region is created. Region can be created by any component that can provide all the required parameters, including page size.

gita-omr commented 3 weeks ago

Requested changes + had some questions. Also, can you add a document outlining what an RSSItem is and looks like, and also what the output report is expected to look like?

Yes, will add it after the review is close to done.

gita-omr commented 2 weeks ago

Rebased.

gita-omr commented 1 week ago

I think I addressed all the comments and I am not planning on adding any new interfaces to that class right now. @dsouzai @0xdaryl could you please take another look?

gita-omr commented 3 days ago

I still need to write a brief document for it.