eclipse / openvsx

An open-source registry for VS Code extensions
https://open-vsx.org/
Eclipse Public License 2.0
1.25k stars 137 forks source link

Missing `publisher.isDomainVerified` property in extension response #453

Open jeanp413 opened 2 years ago

jeanp413 commented 2 years ago

The publisher.isDomainVerified property is missing for extension whose namespace is verified. e.g. from ms marketplace response

{
    "publisherId": "eed56242-9699-4317-8bc7-e9f4b9bdd3ff",
    "publisherName": "redhat",
    "displayName": "Red Hat",
    "flags": "verified",
    "domain": "https://redhat.com",
    "isDomainVerified": true
}

This will enable showing a :heavy_check_mark: in vscode image

amvanbaren commented 2 years ago

@jeanp413 Well, domain is not stored in the database as part of the namespace. domain is also not specified in the extension.vsixmanifest file. Instead, it probably should become part of the namespace ownership claiming process.

Here's the discussion on adding verified domains to vscode: https://github.com/microsoft/vscode/issues/127825. This is how the MS marketplace implemented the domain verification process: https://code.visualstudio.com/api/working-with-extensions/publishing-extension#verify-a-publisher

jeanp413 commented 2 years ago

Ah I see, I thought it was like open-vsx namespace claiming process :smile:

amvanbaren commented 2 years ago

Ah I see, I thought it was like open-vsx namespace claiming process 😄

It can be part of the namespace claiming process. If a namespace owner wants a domain to be added to the namespace they can add domain to the namespace claim Github issue. An input field for domain needs to be added to the admin dashboard. The server needs some extra functionality to check if the domain is verified by querying for a TXT DNS record.