search

eclipse / openvsx

An open-source registry for VS Code extensions
https://open-vsx.org/
Eclipse Public License 2.0
1.23k stars 134 forks source link

Server side rendering #8

Open spoenemann opened 4 years ago

spoenemann commented 4 years ago

Currently the whole content is generated by React in the browser. Crawlers do not execute JavaScript, and so the content should be made available to them with other means.

spoenemann commented 4 years ago
spoenemann commented 4 years ago

Server-side-rendering could be done with GraalVM, but that will require quite some effort to get it right. For example, when loading an extension detail page, we'll need to inject the extension metadata and README content into the script instead of fetching it from the server (we're already on the server).

spoenemann commented 4 years ago

Crawlers do not execute JavaScript

That seems not to be true, at least I can find open-vsx.org extensions on Google search. But server-side-rendering can still be beneficial.

amvanbaren commented 1 year ago

@kineticsquid Do you think this issue is still relevant?

kineticsquid commented 1 year ago

@amvanbaren Good question. @spoenemann @chrisguindon?

chrisguindon commented 1 year ago

@kineticsquid I would say yes. This feature request would help solve my recommendation that I posted on https://github.com/EclipseFdn/open-vsx.org/issues/1240#issuecomment-1305597304

I would recommend that the application is upgraded to include a different description per page.