eclipse / packages

IoT Packages project
https://eclipse.org/packages
Eclipse Public License 2.0
46 stars 66 forks source link

Add nodeSelector, tolerations and serviceAccounts to deployments/statefulsets in Hono Chart #445

Open burhanuguz opened 1 year ago

burhanuguz commented 1 year ago

Hi,

To install hono in production environment effectively, we need to have nodeSelectors, tolerations and serviceAccount definitions in the deployment/statefulset templates.

Since there is no implementation of it, we edited those templates manually and add values to the values yaml. We are deploying every hono deployment/statefulsets to the same nodes so we only put nodeSelector and tolerations variables in those templates. It would be much better if you could add those variables to each deployment/statefulset with _helpers.tpl templating.

spec:
  nodeSelector: {{- toYaml .Values.nodeSelector | nindent 8 }}
  tolerations: {{- toYaml .Values.tolerations | nindent 8 }}
  serviceAccount: {{ .Values.serviceAccountName }}
sophokles73 commented 1 year ago

Thanks for the suggestion. We would be happy to accept a corresponding PR.