search

eclipse / paho.golang

Go libraries
Other
327 stars 92 forks source link

PublishWithOptions() will not return ErrInvalidArguments when QoS is invalid #232

Closed vishnureddy17 closed 6 months ago

vishnureddy17 commented 7 months ago

https://github.com/eclipse/paho.golang/blob/ef0065fea247d5fb388fa82390cedce694e844e1/paho/client.go#L885

This should have ErrInvalidArguments in its tree so the application knows it is a fatal error. This is a very quick fix and I am happy to open a PR for it.

MattBrittan commented 6 months ago

This is a very quick fix and I am happy to open a PR for it.

Please do - keen to get a release out this week and would be nice to have this fixed.

vishnureddy17 commented 6 months ago

Will open a PR today or tomorrow (US Eastern time). Would you like me to incorporate a fix to https://github.com/eclipse/paho.golang/issues/233 as well? @MattBrittan

MattBrittan commented 6 months ago

Would you like me to incorporate a fix to https://github.com/eclipse/paho.golang/issues/233 as well

Yes please.