search

eclipse / paho.golang

Go libraries
Other
327 stars 92 forks source link

Remove MaximumQoS property from CONNECT packet #240

Closed tomatod closed 6 months ago

tomatod commented 6 months ago

Closes #161

According to MQTTv5 spec, Maximum QoS property should not be included in CONNECT packet, but it may be included only in CONNACK packet.

Actually, I included that property in CONNECT and sent it to Mosquitto MQTT server, the connection was refused.

So, I also think we should remove Maximum QoS property from CONNECT packet in this library.

If you like this, I hope you can review this request.

Best Regards,

note: I couldn't pass the test by 'make test' command each in this branch and also master with the following message. It seems to not be related to the change of this branch. 

queue_test.go:208: timeout awaiting messages
...
FAIL    github.com/eclipse/paho.golang/autopaho 5.632s
tomatod commented 6 months ago

I'll cancel this request and check the cause of error after all.