Receive messages on a non-UI thread

HawkiesZA commented 3 years ago

When setting a new callback, messages are received on the UI thread. This completely locks up the UI if there are lots of messages being received. This has been discussed before here: https://github.com/eclipse/paho.mqtt.android/issues/207, but it seems that the solution was never implemented.

Please make sure that the following boxes are checked before submitting your Pull Request, thank you!

[X] You have signed the Eclipse ECA
[X] All of your commits have been signed-off with the correct email address (The same one that you used to sign the CLA)
[X] If This PR fixes an issue, that you reference the issue below. OR if this is a new issue that you are fixing straight away that you add some Description about the bug and how this will fix it.
[ ] If this is new functionality, You have added the appropriate Unit tests.

tabilzad commented 2 years ago

LocalBroadcastManager is a lot more efficient than global broadcasting through context. With the latter if the massage payload is too big - it will throw a TransactionTooLargeException.

HawkiesZA commented 2 years ago

While that may be true, LocalBroadcastManager doesn't appear to have a way to address the problem of locking up the UI thread as explained above. I think this may just be a quick fix under the current situation, but actually we should be looking at a different pattern rather than BroadcastManagers, considering that LocalBroadcastManager has been deprecated as well.

ishdemon commented 11 months ago

Use HiveMqtt instead of paho..its better maintained.

eclipse / paho.mqtt.android

Receive messages on a non-UI thread #459