search

eclipse / paho.mqtt.c

An Eclipse Paho C client library for MQTT for Windows, Linux and MacOS. API documentation: https://eclipse.github.io/paho.mqtt.c/
https://eclipse.org/paho
Other
1.95k stars 1.09k forks source link

Considering NO_PROXY environment variable on Proxy Settings #1473

Open emrahayanoglu opened 5 months ago

emrahayanoglu commented 5 months ago

Is your feature request related to a problem? Please describe. Currently, if we don't set any http/https proxy on the MQTT Client Options, related http and https proxy settings are taken from the environment variables, which de-facto standard environment variables as presented in the nice article from Gitlab guys: https://about.gitlab.com/blog/2021/01/27/we-need-to-talk-no-proxy/ However, as current library is not considering NO_PROXY environment variable on our client settings, which basically leads to introducing additional logic or special docker configurations on our development or testing environments.

Describe the solution you'd like Right thing is to consider also NO_PROXY environment variable on proxy settings of the MQTT Client Options, where if endpoint is in the list of the NO_PROXY, proxy settings will be ignored automatically.

icraggs commented 5 months ago

I think this is a duplicate of #1329

emrahayanoglu commented 3 months ago

@icraggs correct it is absolutely same problem what we experienced. I also go for closing the ticket.