eclipse / paho.mqtt.c

An Eclipse Paho C client library for MQTT for Windows, Linux and MacOS. API documentation: https://eclipse.github.io/paho.mqtt.c/
https://eclipse.org/paho
Other
1.94k stars 1.09k forks source link

MQTTPacket_send has a parameter and a function called "free" #298

Closed GiveMeMoreMtDew closed 7 years ago

GiveMeMoreMtDew commented 7 years ago

The MQTTPacket_send function has an input parameter called "free" and calls the C API function free(). If NO_HEAP_TRACKING is not defined, then the free function is defined as myfree in Heap.h and the compiler does not catch the duplicate meanings. I suggest that you rename the input parameter (ex. freeData) and pass freeData into the 2 functions that currently accept free.

icraggs commented 7 years ago

Good suggestion. Thanks.