`Uncaught TypeError` when bundled with browserify

[alrik]

Hey guys,

I'm currently crafting a realtime sdk and set up a build pipeline with browserify to includes paho.mqtt along with the custom sdk logic.

In the browserify scope the paho.mqtt is required as module.

An error gets raised when messages are send or receive, stating:

Uncaught TypeError: Cannot read property 'length' of undefined
    at ClientImpl.LibraryFactory.ClientImpl._on_socket_message (build.js:2064)
    at WebSocket.<anonymous>

I traced down the error and it hapends due to Paho.MQTT is no global in require context. If we would replace Paho.MQTT with PahoMQTT it will also make it work for browserify builds.

I could submit a PR.

Cheers, Alrik

[rianwouters]

Similar issue here using webpack. Befdore that TypeError I get a connectionLost because Paho is not defined, caused by the fact that Paho it tries to access Paho,MQTT.Message, which is not defined in case webpack is used (i.e. module.exports is defined)

Look very similar to https://github.com/awslabs/aws-mobile-appsync-sdk-js/issues/76 However, the workaround provided there does not work as it defines Paho as {}

I ended up with the following workaround:

import MQTT from 'paho-mqtt'; // Workaround https://github.com/eclipse/paho.mqtt.javascript/issues/150 window.Paho = {MQTT};

Better workarounds appreciated!

[konoufo]

Are there any plans to fix this ?

[deftomat]

Still nothing?

[icraggs]

Hi. The main maintainer of this library @jpwsutton has just gone on vacation for a week or so. He released an updated version in June - I don't know if this is fixed by this update. I'll try and contact him and find out.

What's the easiest way to test it for someone not used to dealing with javascript much, like me?

[konoufo]

@icraggs I could set up a really minimal example test in a repo. This afternoon...

[icraggs]

@konoufo that would be great. I've talked to James, and he thinks he's fixed it with the latest update.

[konoufo]

@icraggs Here it is: https://github.com/konoufo/paho-mqtt-bundle-test Very straightforward.

[icraggs]

Ok, thanks. That worked, as in the problem was reproduced. Then I replaced the paho-mqtt.js with the latest here and the test worked. So the problem is then that the fixed hasn't been packaged into the node.js bundle and/or other locations, presumably.

[konoufo]

Ok great. So at this point, the issue is resolved at this repository level in the last commit ?

[MrSumant]

@icraggs I have the same issue but it is working as expected when i changed the content of paho-mqtt.js with latest master of this repo. So when are guys planning on getting this version to NPM

[pkuczynski]

Any plans for a release @icraggs and @jpwsutton?

[pkuczynski]

@icraggs I can confirm this bug is fixed in the latest release 1.1.0 and can be closed.

[icraggs]

Thanks very much!