search

eclipse / paho.mqtt.javascript

paho.mqtt.javascript
Other
1.15k stars 467 forks source link

start of modern JavaScript workflow #158

Closed ameinhardt closed 2 years ago

ameinhardt commented 6 years ago

Split into modules, build using webpack, providing Socket (with tcp/tls) / Storage to use in chrome app / cordova (with plugin)

ameinhardt commented 6 years ago

The pom based assembly is not working correctly anymore, since webpack is building in /dist, not /target. travis-ci doesn't run tests due to old node.js version. With newer node.js, all tests pass with npm test after npm install ip validation fails, because I sign with my private email, not the work registered with eclipse. the github user is the same, though.

pkuczynski commented 5 years ago

@ameinhardt would you like to solve conflicts?

ameinhardt commented 5 years ago

@pkuczynski: I had completely modularized src/paho-mqtt.js, so that only a stub was left. https://github.com/ameinhardt/paho.mqtt.javascript/blob/develop/src/paho-mqtt.js

I think 'resolving' conflicts would mean to review the commits since May for my branch

pkuczynski commented 5 years ago

Uh uh, this would be a huge work :(

icraggs commented 5 years ago

I didn't think there were many updates to this library since May, so why should there be many conflicts?

Also, the commit hasn't been signed off (as outlined in CONTRIBUTING.md and https://wiki.eclipse.org/Development_Resources/Contributing_via_Git#Signing_off_on_a_commit), so it's failing the IP validation:

The following users have invalid Signed-off-by footers. Please use the Signed-Off-By (git commit -s) mechanism to confirm the origin of the submission. The identity in the Signed-off-By must match the Author or the Committer. ameinhardt

ameinhardt commented 5 years ago

Which commit hasn't been signed off? As mentioned in my previous comment: ip validation fails, because I had worked on your library in my off-work time, so it had to be signed with my private email. The work email is registered with eclipse (also for eclipse unide project). The github user is the same, though.

icraggs commented 5 years ago

Ah, Axel I see. Sorry, thanks for the explanation again. Yes, the commits are all signed off, no problem. I think we need to wait for the EMO response to your email to see what they want to do.

ultrafez commented 5 years ago

Is there any update on this? I'm keen to try this library in my project but without a conventional JS workflow/build in place it's difficult to include the Paho library in our build.

icraggs commented 5 years ago

@ameinhardt could you sign the Eclipse ECA with the email address you used to submit this PR? Maybe it's as simple as that?