search

eclipse / paho.mqtt.javascript

paho.mqtt.javascript
Other
1.14k stars 468 forks source link

Fix typo on will-message connect #159

Closed ghost closed 5 years ago

ghost commented 6 years ago

I noticed something when using paho-mqtt.js in my application, due to linting.

willMessagePayloadBytes is used only in case the message type is "connect". payloadBytes is used only when the message type is "publish".

There seems to be a clear typo in the code, as payloadBytes is used before being defined. I added some comments to make others understand what each variable is used in.

pkuczynski commented 5 years ago

@icraggs looks good to me. Should we merge?

icraggs commented 5 years ago

Hi. Sorry for the late response. For this PR to be merged, the IP checks have to pass. These are the 2 messages:

*The following users do not have valid ECAs. Please see this page for details, or to sign a ECA. filipe.coelho@snuk.io

The following users have invalid Signed-off-by footers. Please use the Signed-Off-By (git commit -s) mechanism to confirm the origin of the submission. The identity in the Signed-off-By must match the Author or the Committer. filipe.coelho@snuk.io*

These requirements are outlined in the CONTRIBUTING.md file. If these criteria can't be fixed then we can reimplement.

ghost commented 5 years ago

The amount of bureaucracy needed to fix a simple typo is really impressive. I will not sign a CLA for this, though I can sign the commit.

icraggs commented 5 years ago

Hi, the reason is, as always, laws and lawyers. One of the purposes of an Open Source foundation such as Eclipse or Apache, is that such rules are enforced to protect the consumers of the software. Principally, the goal is to ensure that the license under which the software is distributed is valid. If a portion of code were copied from a GPL licensed project, for instance, that means that this project could not be licensed under the EPL. The Apache CLA is similar in length and content.

A good guide to Open Source legal implications is here: https://opensource.guide/legal/

For very small contributions this might seem like overkill, but, this in fact is the simpler process! As I said, we can reimplement this if you don't want to sign the ECA.

Thanks

ghost commented 5 years ago

I understand the implications, as you should also understand that you push a lot of developers away with such requirements. I had this PR as a test to see how quickly (or not) a simple fix would go, before submitting bigger changes. Seeing that this is taking months to even get back a response, I am completely unmotivated to push any more changes now.

So yeah, if you want the fix, you will have to reimplement.

icraggs commented 5 years ago

The slowness of a response is a problem yes, which I am attempting to improve. Many of the committers on the project are doing this in their spare time, on a best can do basis.

The requirements for submitting PRs are a consequence of being an Eclipse project - that's not my decision. They are key to allowing organizations to use Eclipse software safely. An ECA only has to be signed once, so the first contribution has the highest hurdle.