search

eclipse / paho.mqtt.m2mqtt

Eclipse Public License 1.0
512 stars 303 forks source link

New override method for Connect() #101

Closed bobmarco closed 5 years ago

bobmarco commented 5 years ago

It recently emerged on our platform the necessity to disable the Clean Session functionality, but unfortunately there is no override method for Connect() which would only take in clientId and cleanSession as arguments. From our testing, the connection attempt fails when passing null username and password, so we can't use any of the existing override methods. The reason why the Connect() method can succefully connect when passing the clientId as the only argument (hence username and password will be null) is still unclear. Signed-off-by: Marco Sacco msacco@balanceinnovations.com

bobmarco commented 5 years ago

@knolleary @ralight @PierreF Can one of you guys please approve my PR? Thank you! https://66.media.tumblr.com/d47cc6cb9bd6e5701bf4e31242660035/tumblr_pfh7huRAVH1toamj8o1_500.gif

icraggs commented 5 years ago

I can do it - looks fine to me.