search

eclipse / paho.mqtt.m2mqtt

Eclipse Public License 1.0
512 stars 303 forks source link

Deferring DNS resolution until connection attempt #121

Open vesuvian opened 4 years ago

vesuvian commented 4 years ago

In my use case I am instantiating an MQTT client at a time where I may not be able to connect to the internet yet. This is causing me problems because MqttNetworkChannel attempts to resolve the configured hostname to an IP address during construction.

By deferring the domain resolution to connection time I am able to keep queuing messages with a disconnected client on one thread, while making connection attempts on another thread, without needing to new up an MQTT client on each attempt, dropping my message queue.

I also see someone else is running into the same problem here: https://github.com/eclipse/paho.mqtt.m2mqtt/issues/119

billbarni commented 4 years ago

Why can't I create a pull request on my fork from your fix? Your pull does not show on the list to me.

vesuvian commented 4 years ago

Is it possible I have confused things by force-pushing a new commit since the original?