search

eclipse / paho.mqtt.python

paho.mqtt.python
Other
2.15k stars 724 forks source link

License: Fix all links for EPL-2.0 #735

Closed pepper-jk closed 6 months ago

pepper-jk commented 1 year ago

Even though the repository is licensed under EPL-2.0, a lot of links pointed to the official copy of EPL-1.0 instead. This is fixed in d7b51ee1442adc2df9d20dd2e0a535def09b4e23.

I also fixed a typo for epl-v20 license file in the MANIFEST.in (7478e83870ea50fd9510aa9f49ade8d18278bee2), which I encountered while fixing the links for EPL-2.0. This appears to be the reason why epl-v20 was not included in any source artifacts of this python package. If I understand this correctly, my change should fix this.

Since this are mostly non-code changes, I did not run the tests, as instructed in the https://github.com/eclipse/paho.mqtt.python/blob/master/CONTRIBUTING.md file. If you could run them yourself, that would be great. If not, let me know and I will try it myself.

Signed-off-by: Jens Keim jens.keim@forvia.com

petersilva commented 9 months ago

can't accept contribution without contributor agreement...

pepper-jk commented 9 months ago

can't accept contribution without contributor agreement...

I actually did sign it after the fact. Unsure why it wont accept it for the test. Anything I'm doing wrong? Maybe I need to use my main github e-mail address. I used the one I created the commits with, like it says in the instructions:

Be sure to use the same email address when you register for the account that you intend to use on Git commit records.

petersilva commented 9 months ago

click on the failure link in this PR thread... it says you accepted the Eclipse one (for org as a whole) but the one for this project is listed as not agreed to yet.

akx commented 6 months ago

Rolled up into #788.

pepper-jk commented 6 months ago

The ECA validation tools is probably complaining because one commit had author with your university email address.

Thanks for the hint. I fixed the faulty author in the first commit.

pepper-jk commented 6 months ago

Rebased onto master. Hope this helps.