search

eclipse / paho.mqtt.python

paho.mqtt.python
Other
2.13k stars 723 forks source link

address #713: remove claims of python2 support, as it is no longer su… #757

Closed petersilva closed 6 months ago

petersilva commented 8 months ago

713 mentions that paho documentation says that it should be compatible with python 2.7. Someone answered that python2.7 is not supported.

So this PR corrects the documentation, and metadata to remove claims about python 2 support for the current version.

gdt commented 8 months ago

This looks good to me. Even if somehow the current codebase did work with 2.7 (despite #713 saying it can't), I think it's just as well to declare that we're done with 2.7, freeing people to do things that break compat, and telling potential users that it won't work. So I'm +1 on merging this.

cclauss commented 8 months ago

@akx Your review, please. Python 2 died 1,392 days ago on 1/1/2020.

akx commented 8 months ago

@cclauss I'm not sure why you'd want my review here?

If anything, @petersilva please add "Closes #714" to the PR's description, so if it does get merged, my "counter-PR" will get closed.

petersilva commented 8 months ago

@akx I updated the original comment to mention #714.

petersilva commented 8 months ago

Weirdly... this PR is approved by @cclauss, but it still isn't merged... what other steps are needed?

akx commented 8 months ago

@petersilva Thanks, but please also add the magic phrase Closes #714 so GitHub will automatically do the right thing if this gets merged.

As for how to get this merged, I don't think @cclauss is a maintainer of this repo, so you'd have to wait for someone else, I suppose – your CI workflows haven't been run yet, for one, and that requires maintainer approval.

cclauss commented 8 months ago

I don't think @cclauss is a maintainer of this repo

Correct. I am not a maintainer of this repo. Maintainers will have a green ✅ next to their pull request approvals but mine above is merely ☑️ .

petersilva commented 8 months ago

Thanks for the clarification... and the review from @cclauss ... magic incantation added for @akx ... awaiting the blessing of the appropriately annointed.

cclauss commented 7 months ago

@ralight @PierreF Can you please tell us if there are still active maintainers of this repo? Serious upgrading like this pull request is needed to keep this codebase up-to-date. Can we at least get these workflows run to see if they pass?

PierreF commented 6 months ago

Thanks for this contribution and for your patience