search

eclipse / paho.mqtt.python

paho.mqtt.python
Other
2.13k stars 723 forks source link

lint-python.yml: Upgrade GitHub Actions #777

Closed cclauss closed 6 months ago

cclauss commented 6 months ago

"3.10" MUST be in quotes in YAML... https://dev.to/hugovk/the-python-3-1-problem-85g

Python 3.12 removes the ssl.wrap_socket() function. https://docs.python.org/3/whatsnew/3.12.html#ssl

Any package that still uses ssl.wrap_socket() is broken and insecure.

% python3.12 ./08-ssl-connect-cert-auth-pw.py python/08-ssl-connect-cert-auth-pw.test

Traceback (most recent call last):
  File "/home/runner/work/paho.mqtt.python/paho.mqtt.python/test/lib/./08-ssl-connect-cert-auth-pw.py", line 25, in <module>
    ssock = paho_test.create_server_socket_ssl(cert_reqs=ssl.CERT_REQUIRED)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/paho.mqtt.python/paho.mqtt.python/test/paho_test.py", line 49, in create_server_socket_ssl
    ssock = ssl.wrap_socket(
            ^^^^^^^^^^^^^^^
AttributeError: module 'ssl' has no attribute 'wrap_socket'

@akx

akx commented 6 months ago

@cclauss the wrap_socket() thing is addressed in https://github.com/eclipse/paho.mqtt.python/pull/771 (as is upgrading the versions)...

cclauss commented 6 months ago

Closing in favor of #771