search

eclipse / paho.mqtt.python

paho.mqtt.python
Other
2.13k stars 723 forks source link

Add more linter #786

Closed PierreF closed 6 months ago

PierreF commented 6 months ago

Add black, codespell and mypy.

mypy is only partially added, mostly to client.py.

akx commented 6 months ago

@PierreF Note that an overarching auto-formatting PR like this will make practically every single other open PR unmergeable and nearly impossible to rebase too. Please consider merging or closing them as suitable before an auto-formatting PR (and an auto-formatting PR should only include auto-formatting).

PierreF commented 6 months ago

@akx thank for your feedback.

I've splitted the PR in multiple PRs:

Closing this PR in favor of other one.

akx commented 6 months ago

@PierreF Thank you, and sorry if my comments sounded a bit harsh – I've just seen the maintenance pain of big PRs like this just steamrolled through 😅