search

eclipse / paho.mqtt.python

paho.mqtt.python
Other
2.13k stars 723 forks source link

Fix grammar, typos #788

Closed akx closed 5 months ago

akx commented 6 months ago

Closes #614 (includes changes from it, plus some reformatting). Closes #660 (includes changes from it, including a missing userdata_set).

akx commented 6 months ago

@PierreF The Python test failures are unrelated (see #789).

PierreF commented 6 months ago

Thank. But I've an issue regarding Eclipse requirement with this PR: since some change are authored by @alexander-minchin which don't seems to have signed the ECA (https://accounts.eclipse.org/user/eca) I'm not sure I'm allowed to merge it.

@alexander-minchin could you complete the ECA signing (https://accounts.eclipse.org/user/eca) with the email you used for the commit (it's the github email: 83529885+alexander-minchin AT users.noreply.github DOT com)

PierreF commented 5 months ago

Since the change is rather small, I think it's okay to merge it even if first author didn't fully complete the ECA.