search

eclipse / paho.mqtt.python

paho.mqtt.python
Other
2.19k stars 722 forks source link

Add typing with mypy #791

Closed PierreF closed 8 months ago

PierreF commented 9 months ago

Split of #786 : contains add of mypy on client.py

PierreF commented 9 months ago

Tests are a bit flappy (not related to this PR, it's also happen on master or other PR). @akx did you also had unstable tests result for PR you created recently (i.e. did you re-run failed tests until they succeed) ? Because if you didn't had to re-run failed test, tests seems to fail more often recently.

Edit: you already answered this question in #789 :)

PierreF commented 9 months ago

Thank for the review. I've only fixed few of your feedback but it's bed time now, I'll continue tomorrow.

PierreF commented 8 months ago

All your comments should be resolved. I think I'll squash-merge this PR due to multiple commits adding the removing thing. If you believe that we should kept multiple commits, I can do a rebase to only squash together part that belong to the same commit (but I want to squash or rebase, because their is change + exact revert of that change in this PR)

akx commented 8 months ago

@PierreF A squash-merge, or a squashing rebase in this PR before merging sounds fine :) In fact, if #791 gets merged (and Codecov gets a baseline of the coverage for master), this could be squash-rebased on master and we'd see the coverage diff here too (hopefully).