Return correct object as client protocol

eclipse / paho.mqtt.python

paho.mqtt.python

Other

2.12k stars 722 forks source link

Return correct object as client protocol #821

Closed asikeero closed 3 months ago

asikeero commented 4 months ago

Fixes #820

PierreF commented 4 months ago

Thanks for catching this error. Could you sign ECA (https://accounts.eclipse.org/user/eca / https://www.eclipse.org/legal/ECA.php) so I can merge you PR ?

asikeero commented 4 months ago

Done, should be OK now.

asikeero commented 4 months ago

Two checks are failing due to reasons that seem not to relate to this PR. Just to clarify, am I expected to add something to this PR to make them pass?

PierreF commented 3 months ago

Thanks for your patience. Pytest (tox) tend to be have false-positive errors (cf #789). The lint_python error is a real error, linked to your change. Your change isn't the issue actually, but make the issue visible: self._protocol is not correctly typed.

I'll merge your PR and fix the typing once merged.

Thanks for your contribution.